Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

org/zmpp/base/DefaultMemoryAccess.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	27
	Line has trailing spaces.	36
	Line has trailing spaces.	37
	Line has trailing spaces.	40
	Parameter data should be final.	43
	'data' hides a field.	43
	Line has trailing spaces.	44
	Line has trailing spaces.	45
	Line has trailing spaces.	47
	Method 'readUnsigned32' is not designed for extension - needs to be abstract, final or empty.	51
	Parameter address should be final.	51
	Line has trailing spaces.	52
	'0xff' is a magic number.	53
	'24' is a magic number.	53
	'0xff' is a magic number.	53
	'16' is a magic number.	53
	'0xff' is a magic number.	54
	'8' is a magic number.	54
	'3' is a magic number.	54
	'0xff' is a magic number.	54
	Line has trailing spaces.	56
	Method 'readUnsignedShort' is not designed for extension - needs to be abstract, final or empty.	60
	Parameter address should be final.	60
	Line has trailing spaces.	61
	'0xff' is a magic number.	62
	'8' is a magic number.	62
	'0xff' is a magic number.	62
	Line has trailing spaces.	64
	Method 'readShort' is not designed for extension - needs to be abstract, final or empty.	68
	Parameter address should be final.	68
	Line has trailing spaces.	69
	'8' is a magic number.	70
	'0xff' is a magic number.	70
	Line has trailing spaces.	72
	Method 'readUnsignedByte' is not designed for extension - needs to be abstract, final or empty.	76
	Parameter address should be final.	76
	Line has trailing spaces.	77
	'0xff' is a magic number.	78
	Line has trailing spaces.	80
	Method 'readByte' is not designed for extension - needs to be abstract, final or empty.	84
	Parameter address should be final.	84
	Line has trailing spaces.	85
	Line has trailing spaces.	88
	Line has trailing spaces.	91
	Method 'writeUnsignedShort' is not designed for extension - needs to be abstract, final or empty.	95
	Parameter address should be final.	95
	Parameter value should be final.	95
	Line has trailing spaces.	96
	'0xff00' is a magic number.	97
	'8' is a magic number.	97
	'0xff' is a magic number.	98
	Line has trailing spaces.	100
	Line has trailing spaces.	103
	Method 'writeShort' is not designed for extension - needs to be abstract, final or empty.	107
	Parameter address should be final.	107
	Parameter value should be final.	107
	Line has trailing spaces.	108
	'0xff00' is a magic number.	109
	'8' is a magic number.	109
	'0xff' is a magic number.	110
	Line has trailing spaces.	112
	Line has trailing spaces.	115
	Method 'writeUnsignedByte' is not designed for extension - needs to be abstract, final or empty.	119
	Parameter address should be final.	119
	Parameter value should be final.	119
	Line has trailing spaces.	120
	'0xff' is a magic number.	121
	Line has trailing spaces.	123
	Line has trailing spaces.	126
	Method 'writeByte' is not designed for extension - needs to be abstract, final or empty.	130
	Parameter address should be final.	130
	Parameter value should be final.	130
	Line has trailing spaces.	131
	Line has trailing spaces.	134
	Line has trailing spaces.	137
	Method 'writeUnsigned32' is not designed for extension - needs to be abstract, final or empty.	141
	Parameter address should be final.	141
	Parameter value should be final.	141
	Line has trailing spaces.	142
	'0xff000000' is a magic number.	143
	'24' is a magic number.	143
	'0x00ff0000' is a magic number.	144
	'16' is a magic number.	144
	'0x0000ff00' is a magic number.	145
	'8' is a magic number.	145
	'3' is a magic number.	146
	'0x000000ff' is a magic number.	146
	Line has trailing spaces.	148

org/zmpp/base/MemoryAccess.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	29
	Line has trailing spaces.	37
	Line has trailing spaces.	42
	Line has trailing spaces.	45
	Line has trailing spaces.	53
	Line has trailing spaces.	58
	Line has trailing spaces.	61
	Line has trailing spaces.	66
	Line has trailing spaces.	69

org/zmpp/base/MemoryReadAccess.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	35
	Line has trailing spaces.	40
	Line has trailing spaces.	43
	Line has trailing spaces.	48
	Line has trailing spaces.	51
	Line has trailing spaces.	56
	Line has trailing spaces.	59
	Line has trailing spaces.	63
	Line has trailing spaces.	64
	Line has trailing spaces.	67

org/zmpp/base/MemorySection.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	30
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Line has trailing spaces.	39
	Missing a Javadoc comment.	40
	Parameter memaccess should be final.	40
	'memaccess' hides a field.	40
	Parameter start should be final.	40
	'start' hides a field.	40
	Parameter length should be final.	40
	'length' hides a field.	40
	Line has trailing spaces.	41
	Line has trailing spaces.	46
	Line has trailing spaces.	49
	Method 'getLength' is not designed for extension - needs to be abstract, final or empty.	52
	Line has trailing spaces.	53
	Line has trailing spaces.	56
	Method 'writeUnsignedShort' is not designed for extension - needs to be abstract, final or empty.	60
	Parameter address should be final.	60
	Parameter value should be final.	60
	Line has trailing spaces.	61
	Method 'writeShort' is not designed for extension - needs to be abstract, final or empty.	68
	Parameter address should be final.	68
	Parameter value should be final.	68
	Line has trailing spaces.	69
	Method 'writeUnsignedByte' is not designed for extension - needs to be abstract, final or empty.	76
	Parameter address should be final.	76
	Parameter value should be final.	76
	Method 'writeByte' is not designed for extension - needs to be abstract, final or empty.	84
	Parameter address should be final.	84
	Parameter value should be final.	84
	Method 'writeUnsigned32' is not designed for extension - needs to be abstract, final or empty.	92
	Parameter address should be final.	92
	Parameter value should be final.	92
	Method 'readUnsigned32' is not designed for extension - needs to be abstract, final or empty.	100
	Parameter address should be final.	100
	Line has trailing spaces.	101
	Method 'readUnsignedShort' is not designed for extension - needs to be abstract, final or empty.	108
	Parameter address should be final.	108
	Line has trailing spaces.	109
	Method 'readShort' is not designed for extension - needs to be abstract, final or empty.	116
	Parameter address should be final.	116
	Line has trailing spaces.	117
	Method 'readUnsignedByte' is not designed for extension - needs to be abstract, final or empty.	124
	Parameter address should be final.	124
	Line has trailing spaces.	125
	Method 'readByte' is not designed for extension - needs to be abstract, final or empty.	132
	Parameter address should be final.	132
	Line has trailing spaces.	133

org/zmpp/debug/LocalTableModel.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Line has trailing spaces.	36
	Missing a Javadoc comment.	37
	Parameter machine should be final.	37
	'machine' hides a field.	37
	Method 'getRowCount' is not designed for extension - needs to be abstract, final or empty.	38
	Missing a Javadoc comment.	38
	'if' construct must use '{}'s.	40
	Method 'getColumnCount' is not designed for extension - needs to be abstract, final or empty.	43
	Missing a Javadoc comment.	43
	Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44
	Parameter column should be final.	44
	Line has trailing spaces.	45
	'if' construct must use '{}'s.	46
	Method 'getValueAt' is not designed for extension - needs to be abstract, final or empty.	49
	Missing a Javadoc comment.	49
	Parameter row should be final.	49
	Parameter column should be final.	49
	Line has trailing spaces.	50
	'if' construct must use '{}'s.	51
	'if' construct must use '{}'s.	54
	Line has trailing spaces.	59
	Method 'update' is not designed for extension - needs to be abstract, final or empty.	60
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	64
	Parameter number should be final.	64
	Line has trailing spaces.	65

org/zmpp/debug/Main.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	43
	Utility classes should not have a public or default constructor.	47
	Missing a Javadoc comment.	49
	Line has trailing spaces.	50
	Missing a Javadoc comment.	51
	Line has trailing spaces.	52
	Missing a Javadoc comment.	53
	Line has trailing spaces.	54
	Line has trailing spaces.	57
	Missing a Javadoc comment.	58
	Parameter flag should be final.	58
	Line has trailing spaces.	59
	Line has trailing spaces.	62
	Missing a Javadoc comment.	63
	Line has trailing spaces.	64
	Line has trailing spaces.	67
	Missing a Javadoc comment.	68
	Line has trailing spaces.	69
	Line has trailing spaces.	72
	Missing a Javadoc comment.	73
	Parameter str should be final.	73
	Line has trailing spaces.	74
	Line has trailing spaces.	78
	Parameter args should be final.	82
	Expected @param tag for 'args'.	82
	Line has trailing spaces.	85
	Line has trailing spaces.	92
	'3' is a magic number.	99
	Line has trailing spaces.	100
	Line has trailing spaces.	104
	Line has trailing spaces.	108
	Line has trailing spaces.	109
	Line has trailing spaces.	111

org/zmpp/debug/ObjectTreeFrame.java

Error		Line
	Got an exception - expecting EOF, found 'for'	0

org/zmpp/debug/ObjectTreeModel.java

Error		Line
	Got an exception - expecting EOF, found 'Machine'	0

org/zmpp/debug/TestFrame.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	61
	Missing a Javadoc comment.	68
	Missing a Javadoc comment.	69
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	73
	Missing a Javadoc comment.	74
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	76
	Line has trailing spaces.	77
	Missing a Javadoc comment.	78
	Missing a Javadoc comment.	79
	Missing a Javadoc comment.	80
	Missing a Javadoc comment.	81
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	83
	Missing a Javadoc comment.	84
	Missing a Javadoc comment.	85
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	87
	Line has trailing spaces.	88
	Missing a Javadoc comment.	89
	Line has trailing spaces.	90
	Missing a Javadoc comment.	91
	Missing a Javadoc comment.	92
	Line has trailing spaces.	93
	Missing a Javadoc comment.	94
	Line has trailing spaces.	95
	'40' is a magic number.	97
	'80' is a magic number.	97
	Line has trailing spaces.	101
	Missing a Javadoc comment.	102
	Line has trailing spaces.	103
	Line has trailing spaces.	106
	Missing a Javadoc comment.	107
	Parameter str should be final.	107
	Line has trailing spaces.	108
	Missing a Javadoc comment.	112
	Variable 'count' must be private and have accessor methods.	112
	Line has trailing spaces.	113
	Missing a Javadoc comment.	114
	Parameter instr should be final.	114
	Line has trailing spaces.	115
	Line has trailing spaces.	120
	Line has trailing spaces.	124
	'if' construct must use '{}'s.	125
	Line has trailing spaces.	128
	Line has trailing spaces.	130
	Line has trailing spaces.	134
	Line has trailing spaces.	136
	Line has trailing spaces.	144
	Missing a Javadoc comment.	145
	Parameter instr should be final.	145
	Parameter operandNum should be final.	145
	Line has trailing spaces.	146
	Line has trailing spaces.	153
	Line has trailing spaces.	160
	Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty.	161
	Missing a Javadoc comment.	161
	Parameter e should be final.	161
	Line has trailing spaces.	162
	Line has trailing spaces.	173
	Line has trailing spaces.	175
	Line is longer than 80 characters.	180
	Avoid inline conditionals.	180
	Line is longer than 80 characters.	181
	Avoid inline conditionals.	181
	Line has trailing spaces.	182
	Line is longer than 80 characters.	183
	Avoid inline conditionals.	183
	Line has trailing spaces.	187
	Missing a Javadoc comment.	188
	Parameter number should be final.	188
	Line has trailing spaces.	189
	Line has trailing spaces.	194
	Missing a Javadoc comment.	195
	Parameter varnum should be final.	195
	Line has trailing spaces.	196
	'if' construct must use '{}'s.	197
	'if' construct must use '{}'s.	198
	'0x10' is a magic number.	198
	'0x10' is a magic number.	199
	Line has trailing spaces.	201
	Missing a Javadoc comment.	202
	Line has trailing spaces.	203
	Line has trailing spaces.	206
	Missing a Javadoc comment.	207
	Line has trailing spaces.	208
	Line is longer than 80 characters.	209
	Line has trailing spaces.	211
	Line has trailing spaces.	212
	Missing a Javadoc comment.	213
	Line has trailing spaces.	214
	Missing a Javadoc comment.	215
	Missing a Javadoc comment.	216
	Line has trailing spaces.	217
	Missing a Javadoc comment.	218
	Parameter machine should be final.	218
	'machine' hides a field.	218
	Missing a Javadoc comment.	219
	'240' is a magic number.	219
	Missing a Javadoc comment.	220
	Missing a Javadoc comment.	221
	Parameter column should be final.	221
	Line has trailing spaces.	222
	'if' construct must use '{}'s.	223
	Missing a Javadoc comment.	226
	Parameter row should be final.	226
	Parameter column should be final.	226
	Line has trailing spaces.	227
	'if' construct must use '{}'s.	228
	'0x10' is a magic number.	230
	Line has trailing spaces.	233
	Missing a Javadoc comment.	234
	Line has trailing spaces.	238
	Missing a Javadoc comment.	239
	Line has trailing spaces.	240
	Missing a Javadoc comment.	241
	Missing a Javadoc comment.	242
	Line has trailing spaces.	243
	Missing a Javadoc comment.	244
	Missing a Javadoc comment.	245
	Parameter inst should be final.	245
	'inst' hides a field.	245
	Line has trailing spaces.	246
	Line has trailing spaces.	249
	Missing a Javadoc comment.	250
	Line has trailing spaces.	252
	Avoid inline conditionals.	255
	Missing a Javadoc comment.	257
	'3' is a magic number.	257
	Missing a Javadoc comment.	258
	Parameter column should be final.	258
	Line has trailing spaces.	259
	'if' construct must use '{}'s.	260
	'if' construct must use '{}'s.	261
	Missing a Javadoc comment.	264
	Parameter row should be final.	264
	Parameter column should be final.	264
	Line has trailing spaces.	265
	'if' construct must use '{}'s.	266
	Line has trailing spaces.	268
	'if' construct must use '{}'s.	269
	'}' should be on the same line.	271
	Line has trailing spaces.	275
	Line is longer than 80 characters.	277
	Line has trailing spaces.	278
	Line has trailing spaces.	280
	Line has trailing spaces.	282
	Line has trailing spaces.	287
	Missing a Javadoc comment.	288
	Line has trailing spaces.	292
	Line has trailing spaces.	293
	Missing a Javadoc comment.	294
	Parameter machine should be final.	294
	'machine' hides a field.	294
	Line has trailing spaces.	295
	Line has trailing spaces.	298
	Line has trailing spaces.	299
	Line has trailing spaces.	301
	'3' is a magic number.	303
	Line has trailing spaces.	307
	Line is longer than 80 characters.	309
	'10' is a magic number.	309
	Line has trailing spaces.	312
	'6' is a magic number.	314
	Line has trailing spaces.	317
	'5' is a magic number.	319
	Line has trailing spaces.	322
	'10' is a magic number.	324
	Line has trailing spaces.	327
	Line is longer than 80 characters.	329
	Avoid inline conditionals.	329
	'6' is a magic number.	329
	Line has trailing spaces.	332
	Line is longer than 80 characters.	334
	Avoid inline conditionals.	334
	'6' is a magic number.	334
	Line has trailing spaces.	337
	Line is longer than 80 characters.	339
	Avoid inline conditionals.	339
	'4' is a magic number.	339
	Line has trailing spaces.	342
	'10' is a magic number.	347
	'80' is a magic number.	347
	Line has trailing spaces.	348
	Line has trailing spaces.	354
	Line has trailing spaces.	357
	'4' is a magic number.	359
	Line has trailing spaces.	360
	'20' is a magic number.	362
	Line has trailing spaces.	363
	'20' is a magic number.	365
	Line is longer than 80 characters.	368
	'20' is a magic number.	368
	Line has trailing spaces.	369
	Line has trailing spaces.	371
	Line has trailing spaces.	380
	Line has trailing spaces.	385
	Line has trailing spaces.	390
	'5' is a magic number.	392
	Line has trailing spaces.	395
	Line has trailing spaces.	397
	Line has trailing spaces.	401
	Line has trailing spaces.	408
	Line has trailing spaces.	413
	Missing a Javadoc comment.	414
	Parameter inst should be final.	414
	Line has trailing spaces.	415
	Line has trailing spaces.	417
	'?' should be on a new line.	421
	Avoid inline conditionals.	421
	Line has trailing spaces.	427
	Missing a Javadoc comment.	428
	Parameter opcode should be final.	428
	Line has trailing spaces.	429
	switch without "default" clause.	430
	Line has trailing spaces.	431
	Line has trailing spaces.	459
	Missing a Javadoc comment.	460
	Parameter opcode should be final.	460
	Line has trailing spaces.	461
	switch without "default" clause.	462
	Line has trailing spaces.	478
	Missing a Javadoc comment.	479
	Parameter opcode should be final.	479
	switch without "default" clause.	481
	Line has trailing spaces.	482
	Line has trailing spaces.	501
	Missing a Javadoc comment.	502
	Parameter opcode should be final.	502
	Line has trailing spaces.	503
	switch without "default" clause.	504
	Missing a Javadoc comment.	521
	Line has trailing spaces.	522
	Missing a Javadoc comment.	523
	Missing a Javadoc comment.	524
	Missing a Javadoc comment.	525
	Line has trailing spaces.	526
	Missing a Javadoc comment.	527
	Parameter parent should be final.	527
	Line has trailing spaces.	529
	'80' is a magic number.	531
	Line has trailing spaces.	541
	Missing a Javadoc comment.	542
	Line has trailing spaces.	543
	Missing a Javadoc comment.	546
	Parameter e should be final.	546
	Line has trailing spaces.	547
	Line has trailing spaces.	551
	Method 'readLine' is not designed for extension - needs to be abstract, final or empty.	552
	Missing a Javadoc comment.	552
	Parameter memaccess should be final.	552
	Parameter address should be final.	552
	Parameter bufferlen should be final.	552
	Line has trailing spaces.	553
	Line has trailing spaces.	559
	Line has trailing spaces.	560

org/zmpp/iff/Chunk.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	29
	Redundant 'static' modifier.	38
	Line has trailing spaces.	39
	Redundant 'static' modifier.	43
	Line has trailing spaces.	44
	Redundant 'static' modifier.	48
	Line has trailing spaces.	50
	Line has trailing spaces.	52
	Line has trailing spaces.	53
	Line has trailing spaces.	57
	Line has trailing spaces.	60
	Line has trailing spaces.	64
	Line has trailing spaces.	67
	Line has trailing spaces.	71
	Line has trailing spaces.	74

org/zmpp/iff/DefaultChunk.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	29
	Variable 'memaccess' must be private and have accessor methods.	38
	Line has trailing spaces.	39
	Line has trailing spaces.	44
	Line has trailing spaces.	49
	Line has trailing spaces.	52
	Parameter memaccess should be final.	55
	'memaccess' hides a field.	55
	Line has trailing spaces.	56
	Line has trailing spaces.	60
	Line has trailing spaces.	62
	Line has trailing spaces.	65
	Line has trailing spaces.	69
	Line has trailing spaces.	72
	Line has trailing spaces.	73
	Line has trailing spaces.	74
	Line has trailing spaces.	76
	Method 'isValid' is not designed for extension - needs to be abstract, final or empty.	80
	Line has trailing spaces.	81
	Method 'getId' is not designed for extension - needs to be abstract, final or empty.	88
	Line has trailing spaces.	89
	Method 'getSize' is not designed for extension - needs to be abstract, final or empty.	96
	Line has trailing spaces.	97
	Line has trailing spaces.	100
	Method 'getMemoryAccess' is not designed for extension - needs to be abstract, final or empty.	104
	Line has trailing spaces.	105

org/zmpp/iff/DefaultFormChunk.java

Error		Line
	Got an exception - expecting EOF, found 'initBaseInfo'	0

org/zmpp/iff/FormChunk.java

Error		Line
	Got an exception - expecting EOF, found 'Chunk'	0

org/zmpp/vm/Abbreviations.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	44
	Line has trailing spaces.	49
	Line has trailing spaces.	52
	Parameter map should be final.	56
	'map' hides a field.	56
	Parameter address should be final.	56
	'address' hides a field.	56
	Line has trailing spaces.	57
	Line has trailing spaces.	61
	First sentence should end with a period.	62
	Line has trailing spaces.	65
	Method 'getWordAddress' is not designed for extension - needs to be abstract, final or empty.	69
	Parameter entryNum should be final.	69
	Line has trailing spaces.	70
	Line has trailing spaces.	72

org/zmpp/vm/AbstractInstruction.java

Error		Line
	Got an exception - expecting EOF, found 'this'	0

org/zmpp/vm/DefaultDictionary.java

Error		Line
	Got an exception - expecting EOF, found 'this'	0

org/zmpp/vm/DefaultStoryFileHeader.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	29
	Line has trailing spaces.	39
	Line has trailing spaces.	42
	Parameter memaccess should be final.	45
	'memaccess' hides a field.	45
	Line has trailing spaces.	46
	Method 'getVersion' is not designed for extension - needs to be abstract, final or empty.	53
	Line has trailing spaces.	54
	Method 'getFlags1' is not designed for extension - needs to be abstract, final or empty.	58
	Line has trailing spaces.	59
	Method 'getRelease' is not designed for extension - needs to be abstract, final or empty.	63
	Line has trailing spaces.	64
	Method 'getHighMemAddress' is not designed for extension - needs to be abstract, final or empty.	68
	'0x04' is a magic number.	68
	Line has trailing spaces.	69
	Method 'getProgramStart' is not designed for extension - needs to be abstract, final or empty.	73
	'0x06' is a magic number.	73
	Line has trailing spaces.	74
	Method 'getDictionaryAddress' is not designed for extension - needs to be abstract, final or empty.	78
	Line has trailing spaces.	79
	'0x08' is a magic number.	80
	Line has trailing spaces.	82
	Method 'getObjectTableAddress' is not designed for extension - needs to be abstract, final or empty.	86
	Line has trailing spaces.	87
	'0x0a' is a magic number.	88
	Line has trailing spaces.	90
	Method 'getGlobalsAddress' is not designed for extension - needs to be abstract, final or empty.	94
	'0x0c' is a magic number.	94
	Line has trailing spaces.	95
	Method 'getStaticsAddress' is not designed for extension - needs to be abstract, final or empty.	99
	'0x0e' is a magic number.	99
	Line has trailing spaces.	100
	Method 'getFlags2' is not designed for extension - needs to be abstract, final or empty.	104
	'0x10' is a magic number.	104
	Line has trailing spaces.	105
	Method 'getSerialNumber' is not designed for extension - needs to be abstract, final or empty.	109
	'0x12' is a magic number.	109
	'6' is a magic number.	109
	Line has trailing spaces.	110
	Method 'getAbbreviationsAddress' is not designed for extension - needs to be abstract, final or empty.	114
	Line has trailing spaces.	115
	'0x18' is a magic number.	116
	Line has trailing spaces.	118
	Method 'getFileLength' is not designed for extension - needs to be abstract, final or empty.	122
	'0x1a' is a magic number.	123
	'if' construct must use '{}'s.	124
	Line has trailing spaces.	124
	'3' is a magic number.	124
	Line has trailing spaces.	127
	Method 'getChecksum' is not designed for extension - needs to be abstract, final or empty.	131
	'0x1c' is a magic number.	131
	Line has trailing spaces.	132
	Method 'getInterpreter' is not designed for extension - needs to be abstract, final or empty.	136
	'0x1e' is a magic number.	136
	Line has trailing spaces.	137
	Method 'getInterpreterVersion' is not designed for extension - needs to be abstract, final or empty.	141
	Line has trailing spaces.	142
	'0x1f' is a magic number.	143
	Line has trailing spaces.	145
	Line has trailing spaces.	149
	Method 'getRevision' is not designed for extension - needs to be abstract, final or empty.	149
	'0x32' is a magic number.	149
	Line has trailing spaces.	154
	Parameter address should be final.	159
	Parameter length should be final.	159
	Line has trailing spaces.	160
	Line has trailing spaces.	163

org/zmpp/vm/DefaultZObject.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	29
	Line has trailing spaces.	40
	Line has trailing spaces.	43
	Line has trailing spaces.	47
	Line has trailing spaces.	50
	Line has trailing spaces.	53
	Line has trailing spaces.	57
	Line has trailing spaces.	60
	Line has trailing spaces.	64
	Line has trailing spaces.	65
	Line has trailing spaces.	68
	Line has trailing spaces.	72
	Line has trailing spaces.	75
	Parameter address should be final.	79
	'address' hides a field.	79
	Line has trailing spaces.	80
	'32' is a magic number.	81
	Line has trailing spaces.	83
	Line has trailing spaces.	86
	Parameter index should be final.	90
	Line has trailing spaces.	91
	Line has trailing spaces.	94
	Line has trailing spaces.	96
	Line has trailing spaces.	98
	Line has trailing spaces.	104
	Line has trailing spaces.	107
	Line has trailing spaces.	111
	Line has trailing spaces.	114
	Line has trailing spaces.	119
	Line has trailing spaces.	122
	Parameter index should be final.	126
	Line has trailing spaces.	127
	Line has trailing spaces.	130
	Line has trailing spaces.	133
	Parameter index should be final.	139
	Parameter bytenum should be final.	139
	Line has trailing spaces.	140
	Line has trailing spaces.	144
	Line has trailing spaces.	147
	Parameter index should be final.	152
	Parameter bytenum should be final.	152
	Parameter value should be final.	152
	Line has trailing spaces.	153
	Line has trailing spaces.	160
	Parameter index should be final.	164
	Line has trailing spaces.	165
	'32' is a magic number.	168
	Line has trailing spaces.	170
	Line has trailing spaces.	173
	Parameter propertyNum should be final.	177
	Line has trailing spaces.	178
	Line has trailing spaces.	180
	'if' construct must use '{}'s.	181
	Line has trailing spaces.	185
	Line has trailing spaces.	188
	Line has trailing spaces.	192
	Line has trailing spaces.	194
	Line has trailing spaces.	196
	Line has trailing spaces.	202
	Line has trailing spaces.	207
	Variable 'address' must be private and have accessor methods.	211
	Line has trailing spaces.	212
	Line has trailing spaces.	217
	Line has trailing spaces.	220
	Parameter memaccess should be final.	223
	'memaccess' hides a field.	223
	Expected @param tag for 'memaccess'.	223
	Parameter address should be final.	223
	'address' hides a field.	223
	Line has trailing spaces.	224
	Line has trailing spaces.	229
	Line has trailing spaces.	232
	Line has trailing spaces.	236
	Line has trailing spaces.	239
	Line has trailing spaces.	242
	Parameter flags32 should be final.	245
	Line has trailing spaces.	246
	Method 'isAttributeSet' is not designed for extension - needs to be abstract, final or empty.	253
	Parameter attributeNum should be final.	253
	Line has trailing spaces.	254
	'0x0000000080000000l' is a magic number.	255
	Should use uppercase 'L'.	255
	Method 'setAttribute' is not designed for extension - needs to be abstract, final or empty.	262
	Parameter attributeNum should be final.	262
	Line has trailing spaces.	263
	'0x0000000080000000l' is a magic number.	264
	Should use uppercase 'L'.	264
	Method 'clearAttribute' is not designed for extension - needs to be abstract, final or empty.	272
	Parameter attributeNum should be final.	272
	Line has trailing spaces.	273
	'0xffffffff7fffffffl' is a magic number.	274
	Should use uppercase 'L'.	274
	Line has trailing spaces.	276
	Method 'getParent' is not designed for extension - needs to be abstract, final or empty.	282
	Line has trailing spaces.	283
	'4' is a magic number.	284
	Line has trailing spaces.	286
	Method 'setParent' is not designed for extension - needs to be abstract, final or empty.	290
	Parameter parent should be final.	290
	Line has trailing spaces.	291
	'4' is a magic number.	292
	'0xff' is a magic number.	292
	Line has trailing spaces.	294
	Method 'getSibling' is not designed for extension - needs to be abstract, final or empty.	298
	Line has trailing spaces.	299
	'5' is a magic number.	300
	Line has trailing spaces.	302
	Method 'setSibling' is not designed for extension - needs to be abstract, final or empty.	306
	Parameter sibling should be final.	306
	Line has trailing spaces.	307
	'5' is a magic number.	308
	'0xff' is a magic number.	308
	Line has trailing spaces.	310
	Method 'getChild' is not designed for extension - needs to be abstract, final or empty.	314
	Line has trailing spaces.	315
	'6' is a magic number.	316
	Line has trailing spaces.	318
	Method 'setChild' is not designed for extension - needs to be abstract, final or empty.	322
	Parameter child should be final.	322
	Line has trailing spaces.	323
	'6' is a magic number.	324
	'0xff' is a magic number.	324
	Line has trailing spaces.	326
	Method 'getPropertyTableAddress' is not designed for extension - needs to be abstract, final or empty.	330
	Line has trailing spaces.	331
	'7' is a magic number.	332
	Method 'getPropertiesDescriptionAddress' is not designed for extension - needs to be abstract, final or empty.	338
	Line has trailing spaces.	339
	Method 'getNumProperties' is not designed for extension - needs to be abstract, final or empty.	346
	Line has trailing spaces.	347
	Method 'getPropertySize' is not designed for extension - needs to be abstract, final or empty.	354
	Parameter property should be final.	354
	Line has trailing spaces.	355
	Line has trailing spaces.	359
	Method 'getPropertyByte' is not designed for extension - needs to be abstract, final or empty.	363
	Parameter property should be final.	363
	Parameter bytenum should be final.	363
	Line has trailing spaces.	364
	Method 'getPropertyAddress' is not designed for extension - needs to be abstract, final or empty.	372
	Parameter property should be final.	372
	Line has trailing spaces.	373
	Method 'isPropertyAvailable' is not designed for extension - needs to be abstract, final or empty.	381
	Parameter property should be final.	381
	Line has trailing spaces.	382
	Method 'getNextProperty' is not designed for extension - needs to be abstract, final or empty.	389
	Parameter property should be final.	389
	Line has trailing spaces.	390
	Line has trailing spaces.	392
	Line has trailing spaces.	394
	Line has trailing spaces.	396
	Line has trailing spaces.	401
	Method 'setPropertyByte' is not designed for extension - needs to be abstract, final or empty.	405
	Parameter property should be final.	405
	Parameter bytenum should be final.	405
	Parameter value should be final.	405
	Line has trailing spaces.	406

org/zmpp/vm/Dictionary.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	36
	Line has trailing spaces.	40
	Line has trailing spaces.	43
	Line has trailing spaces.	48
	Line has trailing spaces.	51
	Line has trailing spaces.	55
	Line has trailing spaces.	58
	Line has trailing spaces.	62
	Line has trailing spaces.	65
	Line has trailing spaces.	70
	Line has trailing spaces.	75

org/zmpp/vm/InputStream.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	29
	Line has trailing spaces.	37

org/zmpp/vm/Instruction.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	28

org/zmpp/vm/InstructionDecoder.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	31
	Line has trailing spaces.	36
	Line has trailing spaces.	41
	Line has trailing spaces.	46
	Line has trailing spaces.	49
	Parameter machineState should be final.	52
	'machineState' hides a field.	52
	Expected @param tag for 'machineState'.	52
	Parameter memaccess should be final.	53
	'memaccess' hides a field.	53
	Line has trailing spaces.	54
	Line has trailing spaces.	58
	Line has trailing spaces.	61
	Method 'decodeInstruction' is not designed for extension - needs to be abstract, final or empty.	65
	Parameter instructionAddress should be final.	65
	Line has trailing spaces.	66
	Line has trailing spaces.	71
	Line has trailing spaces.	74
	Line has trailing spaces.	76
	Line has trailing spaces.	83
	Line has trailing spaces.	86
	Line has trailing spaces.	96
	Unused @param tag for 'the'.	97
	Line is longer than 80 characters.	100
	Parameter instructionAddress should be final.	100
	Expected @param tag for 'instructionAddress'.	100
	Line has trailing spaces.	101
	Line has trailing spaces.	105
	'0x7f' is a magic number.	107
	Line has trailing spaces.	108
	'0x1f' is a magic number.	109
	'0x80' is a magic number.	113
	'0xbf' is a magic number.	113
	Line has trailing spaces.	114
	'0x0f' is a magic number.	115
	'0xb0' is a magic number.	116
	Avoid inline conditionals.	116
	':' should be on a new line.	116
	Line has trailing spaces.	119
	Line has trailing spaces.	124
	'}' should be on the same line.	129
	'else' construct must use '{}'s.	130
	Line has trailing spaces.	132
	Line has trailing spaces.	134
	'0x1f' is a magic number.	135
	'0xe0' is a magic number.	136
	Avoid inline conditionals.	136
	Line has trailing spaces.	140
	Line has trailing spaces.	145
	Line is longer than 80 characters.	150
	Parameter info should be final.	150
	Parameter instructionAddress should be final.	150
	Line has trailing spaces.	153
	Line has trailing spaces.	155
	Line has trailing spaces.	157
	'0x30' is a magic number.	164
	'4' is a magic number.	164
	Line has trailing spaces.	166
	Line has trailing spaces.	168
	Line has trailing spaces.	170
	Line has trailing spaces.	176
	'0x40' is a magic number.	178
	Avoid inline conditionals.	178
	':' should be on a new line.	178
	'0x20' is a magic number.	180
	Avoid inline conditionals.	180
	':' should be on a new line.	180
	Line has trailing spaces.	184
	'{' is not preceded with whitespace.	185
	Line has trailing spaces.	186
	Line has trailing spaces.	188
	Line has trailing spaces.	190
	Line has trailing spaces.	196
	Line has trailing spaces.	201
	Parameter info should be final.	207
	Parameter optypeByte should be final.	208
	Parameter currentAddress should be final.	208
	Line has trailing spaces.	209
	'6' is a magic number.	212
	'0x03' is a magic number.	212
	Line has trailing spaces.	213
	'4' is a magic number.	214
	Line has trailing spaces.	215
	'3' is a magic number.	216
	'0x03' is a magic number.	216
	'if' construct must use '{}'s.	219
	Line has trailing spaces.	223
	Line has trailing spaces.	228
	Parameter info should be final.	234
	Parameter optype should be final.	234
	Parameter currentAddress should be final.	235
	Line has trailing spaces.	239
	Line has trailing spaces.	242
	Line has trailing spaces.	246
	Line has trailing spaces.	249
	Line has trailing spaces.	252
	Line has trailing spaces.	253
	Line has trailing spaces.	257
	Line has trailing spaces.	260
	Line is longer than 80 characters.	265
	Parameter info should be final.	265
	Parameter currentAddress should be final.	265
	Line has trailing spaces.	266
	Line has trailing spaces.	268
	Line has trailing spaces.	274
	Line has trailing spaces.	277
	Line is longer than 80 characters.	282
	Parameter info should be final.	282
	Parameter currentAddress should be final.	282
	Line has trailing spaces.	283
	Line has trailing spaces.	285
	'0x80' is a magic number.	287
	Line has trailing spaces.	289
	'0x40' is a magic number.	291
	Line has trailing spaces.	292
	'0x3f' is a magic number.	293
	Line has trailing spaces.	295
	Line has trailing spaces.	297
	Line has trailing spaces.	300
	'0x20' is a magic number.	301
	Line has trailing spaces.	302
	'0xC000' is a magic number.	304
	'8' is a magic number.	304
	'0xff' is a magic number.	304
	Line has trailing spaces.	305
	Line has trailing spaces.	307
	'0x3f' is a magic number.	309
	'8' is a magic number.	309
	'0xff' is a magic number.	309

org/zmpp/vm/LongInstruction.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line has trailing spaces.	3
	Line has trailing spaces.	30
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	52
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	58
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	63
	Line has trailing spaces.	64
	Line has trailing spaces.	69
	Line has trailing spaces.	72
	Parameter machineState should be final.	76
	Parameter opcode should be final.	76
	Line has trailing spaces.	77
	Line has trailing spaces.	81
	Line has trailing spaces.	84
	Parameter machineState should be final.	89
	Parameter operandCount should be final.	90
	'operandCount' hides a field.	90
	Parameter opcode should be final.	90
	Line has trailing spaces.	91
	Line has trailing spaces.	95
	Method 'execute' is not designed for extension - needs to be abstract, final or empty.	99
	Line has trailing spaces.	100
	Line has trailing spaces.	102
	Line has trailing spaces.	138
	Line has trailing spaces.	147
	Line has trailing spaces.	150
	Line has trailing spaces.	153
	Line has trailing spaces.	156
	Line has trailing spaces.	159
	Line has trailing spaces.	179
	Method 'getInstructionForm' is not designed for extension - needs to be abstract, final or empty.	183
	Line has trailing spaces.	184
	Method 'getOperandCount' is not designed for extension - needs to be abstract, final or empty.	188
	Line has trailing spaces.	189
	Method 'storesResult' is not designed for extension - needs to be abstract, final or empty.	193
	Line has trailing spaces.	194
	Line has trailing spaces.	213
	Method 'isBranch' is not designed for extension - needs to be abstract, final or empty.	217
	Line has trailing spaces.	218
	Line has trailing spaces.	233
	Missing a Javadoc comment.	234
	Line has trailing spaces.	235
	'+' should be on a new line.	240
	Line has trailing spaces.	243
	Line has trailing spaces.	245
	Line has trailing spaces.	247
	Line has trailing spaces.	255
	Missing a Javadoc comment.	256
	Line has trailing spaces.	257
	Line has trailing spaces.	262
	Missing a Javadoc comment.	263
	Line has trailing spaces.	264
	Line has trailing spaces.	269
	Missing a Javadoc comment.	270
	Line has trailing spaces.	271
	Line has trailing spaces.	273
	Line has trailing spaces.	277
	Missing a Javadoc comment.	278
	Line has trailing spaces.	279
	Line has trailing spaces.	283
	Line has trailing spaces.	287
	Missing a Javadoc comment.	288
	Line has trailing spaces.	289
	Line has trailing spaces.	293
	Line has trailing spaces.	297
	Missing a Javadoc comment.	298
	Line has trailing spaces.	299
	Line has trailing spaces.	304
	Missing a Javadoc comment.	305
	Line has trailing spaces.	306
	'0xffff' is a magic number.	309
	Line has trailing spaces.	312
	Missing a Javadoc comment.	313
	Line has trailing spaces.	314
	'0xffff' is a magic number.	317
	Line has trailing spaces.	320
	Missing a Javadoc comment.	321
	Line has trailing spaces.	322
	Line has trailing spaces.	328
	Missing a Javadoc comment.	329
	Line has trailing spaces.	330
	Line has trailing spaces.	336
	Missing a Javadoc comment.	337
	Line has trailing spaces.	338
	'cast' is not followed by whitespace.	341
	Line has trailing spaces.	344
	Missing a Javadoc comment.	345
	Line has trailing spaces.	346
	Line has trailing spaces.	352
	Missing a Javadoc comment.	353
	Line has trailing spaces.	354
	Line has trailing spaces.	360
	Missing a Javadoc comment.	361
	Line has trailing spaces.	362
	Line has trailing spaces.	368
	Missing a Javadoc comment.	369
	Line has trailing spaces.	370
	Line has trailing spaces.	377
	Missing a Javadoc comment.	378
	Line has trailing spaces.	379
	Line has trailing spaces.	386
	Missing a Javadoc comment.	387
	Line has trailing spaces.	388
	Line has trailing spaces.	391
	Line has trailing spaces.	394
	Line has trailing spaces.	396
	Line has trailing spaces.	398
	Line has trailing spaces.	403
	Missing a Javadoc comment.	404
	Line has trailing spaces.	405
	Line has trailing spaces.	412
	Missing a Javadoc comment.	413
	Line has trailing spaces.	414
	Line has trailing spaces.	421
	Missing a Javadoc comment.	422
	Line has trailing spaces.	423
	Line has trailing spaces.	430
	Missing a Javadoc comment.	431
	Line has trailing spaces.	432
	Line has trailing spaces.	438
	Line has trailing spaces.	440
	Line has trailing spaces.	443
	Line has trailing spaces.	445
	Line has trailing spaces.	447
	Line has trailing spaces.	449
	Line has trailing spaces.	451
	'8' is a magic number.	452
	'0xff' is a magic number.	452
	Line has trailing spaces.	457
	Missing a Javadoc comment.	458
	Line has trailing spaces.	459
	Line has trailing spaces.	462
	Line has trailing spaces.	465
	Line has trailing spaces.	467
	'0xffff' is a magic number.	468
	Line has trailing spaces.	473
	Missing a Javadoc comment.	474
	Line has trailing spaces.	475
	Line has trailing spaces.	480
	Line has trailing spaces.	482
	'0xffff' is a magic number.	483
	Line has trailing spaces.	486
	Line has trailing spaces.	488